Re: [PATCH v8 2/2] dt-bindings:thermal: Add Sunplus schema

From: Rob Herring
Date: Tue May 03 2022 - 13:50:13 EST


On Tue, May 03, 2022 at 10:13:08AM +0800, Li-hao Kuo wrote:
> Add bindings for Sunplus thermal driver
>
> Signed-off-by: Li-hao Kuo <lhjeff911@xxxxxxxxx>
> ---
> Changes in v8:
> - Modify yaml file.
> modify the setting compatible
> - Change yaml file name.
> - Modify driver.
> mosdify and simply the nvmem setting and remove valiable
>
> .../bindings/thermal/sunplus,thermal.yaml | 43 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml
>
> diff --git a/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml b/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml
> new file mode 100644
> index 0000000..1ecf6f6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/sunplus,thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus Thermal controller
> +
> +maintainers:
> + - Li-hao Kuo <lhjeff911@xxxxxxxxx>
> +
> +properties:
> + compatible:
> + enum:
> + - sunplus,thermal

I don't think is is what was suggested. This must be SoC specific.

> +
> + reg:
> + maxItems: 1
> +
> + nvmem-cells:
> + maxItems: 1
> +
> + nvmem-cell-names:
> + const: calib
> +
> +required:
> + - compatible
> + - reg
> + - nvmem-cells
> + - nvmem-cell-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + thermal@9c000280 {
> + compatible = "sunplus,thermal";
> + reg = <0x9c000280 0xc>;
> + nvmem-cells = <&calib>;
> + nvmem-cell-names = "calib";
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 82143ff..ff49023 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18900,6 +18900,7 @@ SUNPLUS THERMAL DRIVER
> M: Li-hao Kuo <lhjeff911@xxxxxxxxx>
> L: linux-pm@xxxxxxxxxxxxxxx
> S: Maintained
> +F: Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml
> F: drivers/thermal/sunplus_thermal.c
>
> SUNPLUS UART DRIVER
> --
> 2.7.4
>
>