Re: [PATCH 1/2] dt-bindings: power: Add MediaTek Helio X10 MT6795 power domains

[AngeloGioacchino Del Regno]

Il 03/05/22 14:38, Krzysztof Kozlowski ha scritto:
> On 03/05/2022 12:54, AngeloGioacchino Del Regno wrote:
> > Add power domains dt-bindings for MediaTek Helio X10 (MT6795).
> >
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > ---
> >   .../power/mediatek,power-controller.yaml         |  2 ++
> >   include/dt-bindings/power/mt6795-power.h         | 16 ++++++++++++++++
> >   2 files changed, 18 insertions(+)
> >   create mode 100644 include/dt-bindings/power/mt6795-power.h
> >
> > diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> > index 135c6f722091..b448101fac43 100644
> > --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> > +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> > @@ -23,6 +23,7 @@ properties:
> >   
> >     compatible:
> >       enum:
> > +      - mediatek,mt6795-power-controller
> >         - mediatek,mt8167-power-controller
> >         - mediatek,mt8173-power-controller
> >         - mediatek,mt8183-power-controller
> > @@ -62,6 +63,7 @@ patternProperties:
> >         reg:
> >           description: |
> >             Power domain index. Valid values are defined in:
> > +              "include/dt-bindings/power/mt6795-power.h" - for MT8167 type power domain.
> >                 "include/dt-bindings/power/mt8167-power.h" - for MT8167 type power domain.
> >                 "include/dt-bindings/power/mt8173-power.h" - for MT8173 type power domain.
> >                 "include/dt-bindings/power/mt8183-power.h" - for MT8183 type power domain.
> > diff --git a/include/dt-bindings/power/mt6795-power.h b/include/dt-bindings/power/mt6795-power.h
> > new file mode 100644
> > index 000000000000..0e27bc7fa748
> > --- /dev/null
> > +++ b/include/dt-bindings/power/mt6795-power.h
> > @@ -0,0 +1,16 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
>
> If it is not a derivative work, should be GPL-2.0 OR BSD

On that, I agree with you, fully.

Though, all of the mt(xxxx)-power.h headers provide this license tag and I
wanted to follow that to give the same.

Should I change it to (GPL-2.0-only OR BSD-2-Clause)?

Regards,
Angelo

> Best regards,
> Krzysztof