Re: [PATCH 1/3] PCI: apple: GPIO handling nitfixes

From: Hector Martin
Date: Mon May 02 2022 - 08:16:51 EST


On 02/05/2022 19.20, Marc Zyngier wrote:
> On Mon, 02 May 2022 10:38:30 +0100,
> Hector Martin <marcan@xxxxxxxxx> wrote:
>>
>> - Use devm managed GPIO getter
>> - GPIO ops can sleep in this context
>>
>> Fixes: 1e33888fbe44 ("PCI: apple: Add initial hardware bring-up")
>> Cc: stable@xxxxxxxxxxxxxxx
>
> Why the Cc: stable? I'd guess that at a push, the devm_*() usage help
> with potential memory leaks when the driver fails to probe, but it
> would be good to call that out in the commit message.

Ack, I mentioned what this fixes for v2 and reworded the commit message.

--
Hector Martin (marcan@xxxxxxxxx)
Public Key: https://mrcn.st/pub