Re: [PATCH 0/3] drm: Allow simpledrm to setup its emulated FB as firmware provided

From: Javier Martinez Canillas
Date: Mon May 02 2022 - 06:52:13 EST


Hello Thomas,

On 5/2/22 12:35, Thomas Zimmermann wrote:
> Hi Javier
>
> Am 02.05.22 um 10:48 schrieb Javier Martinez Canillas:
>> Hello,
>>
>> This series contain patches suggested by Thomas Zimmermannas a feedback for

Ups, I missed a space here. I meant to write "Zimmermann as a feedback..."

>> "[RFC PATCH v4 00/11] Fix some race between sysfb device registration and
>> drivers probe" [0].
>>
>> Since other changes in [0] were more controversial, I decided to just split
>> this part in a new patch-set and revisit the rest of the patches later.
>>
>> Patch #1 is just a cleanup since when working on this noticed that some DRM
>> drivers were passing as preferred bits per pixel to drm_fbdev_generic_setup()
>> the value that is the default anyways.
>>
>> Patch #2 renames the 'preferred_bpp' drm_fbdev_generic_setup() parameter to
>> 'options', and make this a multi field parameter so that it can be extended
>> later to pass other options as well.
>>
>> Patch #3 finally adds the new DRM_FB_FW option and makes simpledrm to use it
>> so that the registered framebuffer device is also marked as firmware provided.
>
> For the whole patchset:
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
>
> Thanks a lot!
>

Thanks for the prompt review!

--
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat