Re: [PATCH V9 10/24] LoongArch: Add exception/interrupt handling

From: Xi Ruoyao
Date: Sun May 01 2022 - 13:08:53 EST


On Mon, 2022-05-02 at 00:27 +0800, Xi Ruoyao wrote:
> On Sat, 2022-04-30 at 17:05 +0800, Huacai Chen wrote:
> > +struct acpi_madt_lio_pic;
> > +struct acpi_madt_eio_pic;
> > +struct acpi_madt_ht_pic;
> > +struct acpi_madt_bio_pic;
> > +struct acpi_madt_msi_pic;
> > +struct acpi_madt_lpc_pic;
>
> Where are those defined?  I can't find them and the compilation fails
> with:
>
> arch/loongarch/kernel/irq.c: In function ‘find_pch_pic’:
> arch/loongarch/kernel/irq.c:48:32: error: invalid use of undefined
> type ‘struct acpi_madt_bio_pic’
>    48 |                 start = irq_cfg->gsi_base;
>       |                                ^~
> arch/loongarch/kernel/irq.c:49:32: error: invalid use of undefined
> type ‘struct acpi_madt_bio_pic’
>    49 |                 end   = irq_cfg->gsi_base + irq_cfg->size;
>       |                                ^~
> arch/loongarch/kernel/irq.c:49:52: error: invalid use of undefined
> type ‘struct acpi_madt_bio_pic’
>    49 |                 end   = irq_cfg->gsi_base + irq_cfg->size;
>       |                                                    ^~

Alright, my bad... I didn't realize the LoongArch patches are splitted
into multiple series for multiple lists. But is this the SOP of kernel
patch reviewing? Would it be easier to just send one series and CC all
relevent lists?

--
Xi Ruoyao <xry111@xxxxxxxxxxxxxxxx>
School of Aerospace Science and Technology, Xidian University