Re: [PATCH v2 4/8] dt-bindings: riscv: microchip: document icicle reference design

From: Conor Dooley
Date: Sun May 01 2022 - 06:42:02 EST




On 01/05/2022 09:57, Krzysztof Kozlowski wrote:
> On 30/04/2022 15:09, Conor Dooley wrote:
>> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>>
>> Add a compatible for the icicle kit's reference design. This represents
>> the FPGA fabric's contents & is versioned to denote which release of the
>> reference design it applies to.
>>
>> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>> Signed-off-by: Conor Dooley <mail@xxxxxxxxxxx>
>> ---
>> .../devicetree/bindings/riscv/microchip.yaml | 11 +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/riscv/microchip.yaml b/Documentation/devicetree/bindings/riscv/microchip.yaml
>> index 3f981e897126..c9d8fcc7a69e 100644
>> --- a/Documentation/devicetree/bindings/riscv/microchip.yaml
>> +++ b/Documentation/devicetree/bindings/riscv/microchip.yaml
>> @@ -17,10 +17,13 @@ properties:
>> $nodename:
>> const: '/'
>> compatible:
>> - items:
>> - - enum:
>> - - microchip,mpfs-icicle-kit
>> - - const: microchip,mpfs
>> + oneOf:
>> + - items:
>> + - enum:
>> + - microchip,mpfs-icicle-kit
>> + - const: microchip,mpfs
>
> Blank line.
>
>> + - items:
>> + - const: microchip,mpfs-icicle-reference-rtlv2203
>
> Why is this not compatible with microchip,mpfs?

I guess it should be, I'll add it. Thanks.