Re: [PATCH 1/2] mm: slab: fix comment for ARCH_KMALLOC_MINALIGN

From: Vlastimil Babka
Date: Fri Apr 29 2022 - 05:41:26 EST


On 4/28/22 17:59, andrey.konovalov@xxxxxxxxx wrote:
> From: Andrey Konovalov <andreyknvl@xxxxxxxxxx>
>
> The comment next to the ARCH_KMALLOC_MINALIGN definition says that
> ARCH_KMALLOC_MINALIGN can be defined in arch headers. This is incorrect:
> it's actually ARCH_DMA_MINALIGN that can be defined there.
>
> Fix the comment.
>
> Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx>

Thanks, added both patches to the slab tree.

> ---
> include/linux/slab.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/slab.h b/include/linux/slab.h
> index 373b3ef99f4e..8cc1d54e56ad 100644
> --- a/include/linux/slab.h
> +++ b/include/linux/slab.h
> @@ -190,7 +190,7 @@ void kmem_dump_obj(void *object);
> /*
> * Some archs want to perform DMA into kmalloc caches and need a guaranteed
> * alignment larger than the alignment of a 64-bit integer.
> - * Setting ARCH_KMALLOC_MINALIGN in arch headers allows that.
> + * Setting ARCH_DMA_MINALIGN in arch headers allows that.
> */
> #if defined(ARCH_DMA_MINALIGN) && ARCH_DMA_MINALIGN > 8
> #define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN