Re: [dm-devel] [PATCH v4 00/10] Add Copy offload support

[Bart Van Assche]

On 4/28/22 14:37, Damien Le Moal wrote:
> On 4/28/22 16:49, Nitesh Shetty wrote:
> > On Thu, Apr 28, 2022 at 07:05:32AM +0900, Damien Le Moal wrote:
> > > On 4/27/22 21:49, Nitesh Shetty wrote:
> > > > O Wed, Apr 27, 2022 at 11:19:48AM +0900, Damien Le Moal wrote:
> > > > > On 4/26/22 19:12, Nitesh Shetty wrote:
> > > > > > The patch series covers the points discussed in November 2021 virtual call
> > > > > > [LSF/MM/BFP TOPIC] Storage: Copy Offload[0].
> > > > > > We have covered the Initial agreed requirements in this patchset.
> > > > > > Patchset borrows Mikulas's token based approach for 2 bdev
> > > > > > implementation.
> > > > > >
> > > > > > Overall series supports –
> > > > > >
> > > > > > 1. Driver
> > > > > > - NVMe Copy command (single NS), including support in nvme-target (for
> > > > > >      block and file backend)
> > > > >
> > > > > It would also be nice to have copy offload emulation in null_blk for testing.
> > > >
> > > > We can plan this in next phase of copy support, once this series settles down.
> > >
> > > So how can people test your series ? Not a lot of drives out there with
> > > copy support.
> >
> > Yeah not many drives at present, Qemu can be used to test NVMe copy.
>
> Upstream QEMU ? What is the command line options ? An example would be
> nice. But I still think null_blk support would be easiest.

+1 for adding copy offloading support in null_blk. That enables running 
copy offloading tests without depending on Qemu.

Thanks,

Bart.