Re: [PATCH net-next v2 2/2] net: tcp: add skb drop reasons to route_req()

[Menglong Dong]

On Thu, Apr 28, 2022 at 9:22 PM Toke Høiland-Jørgensen <toke@xxxxxxxxxx> wrote:
>
> menglong8.dong@xxxxxxxxx writes:
>
> > From: Menglong Dong <imagedong@xxxxxxxxxxx>
> >
> > Add skb drop reasons to the route_req() in struct tcp_request_sock_ops.
> > Following functions are involved:
> >
> >   tcp_v4_route_req()
> >   tcp_v6_route_req()
> >   subflow_v4_route_req()
> >   subflow_v6_route_req()
> >
> > And the new reason SKB_DROP_REASON_SECURITY is added, which is used when
> > skb is dropped by LSM.
>
> Could we maybe pick a slightly less generic name? If I saw
> "SKB_DROP_REASON_SECURITY" my first thought would be something related
> to *network* security, like a firewall. Maybe just SKB_DROP_REASON_LSM?
>

Thanks for your suggestion, and I think SKB_DROP_REASON_LSM is fine.
I'll change it in the next version.

Menglong Dong

> -Toke
>