Re: [PATCH v5 2/5] dt-bindings: regulator: Add bindings for Silicon Mitus SM5703 regulators

[Markuss Broks]

Hi Rob,

On 4/28/22 19:36, Rob Herring wrote:
> On Sat, Apr 23, 2022 at 3:54 AM Markuss Broks <markuss.broks@xxxxxxxxx> wrote:
> > This patch adds device-tree bindings for regulators on Silicon Mitus
> > SM5703 MFD.
> >
> > Signed-off-by: Markuss Broks <markuss.broks@xxxxxxxxx>
> > ---
> >   .../siliconmitus,sm5703-regulator.yaml        | 49 +++++++++++++++++++
> >   1 file changed, 49 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/regulator/siliconmitus,sm5703-regulator.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/siliconmitus,sm5703-regulator.yaml b/Documentation/devicetree/bindings/regulator/siliconmitus,sm5703-regulator.yaml
> > new file mode 100644
> > index 000000000000..75ff16b58000
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/siliconmitus,sm5703-regulator.yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/regulator/siliconmitus,sm5703-regulator.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Silicon Mitus SM5703 multi function device regulators
> > +
> > +maintainers:
> > +  - Markuss Broks <markuss.broks@xxxxxxxxx>
> > +
> > +description: |
> > +  SM5703 regulators node should be a sub node of the SM5703 MFD node. See SM5703 MFD
> > +  bindings at Documentation/devicetree/bindings/mfd/siliconmitus,sm5703.yaml
> > +  Regulator nodes should be named as USBLDO_<number>, BUCK, VBUS, LDO_<number>.
> > +  The definition for each of these nodes is defined using the standard
> > +  binding for regulators at Documentation/devicetree/bindings/regulator/regulator.txt.
> > +
> > +properties:
> > +  buck:
> > +    type: object
> > +    $ref: regulators.yaml#
> The correct file is regulator.yaml.
I was applying all the suggestions, and I thought I had somehow made a 
typo referring to a wrong file.

Do I re-send the whole series with just the s/regulators/regulator/g? A 
part of series has already been merged, do I not re-send the already 
merged patches then?

> That's indicated by this warning:
>
> schemas/regulator/regulators.yaml: ignoring, error parsing file
>
> It will fail worse than that once the example in the MFD file is added.
>
> Lee, Mark, I've said it before, but MFD plus child schemas need to be
> applied together. Maybe no one cares if dt_binding_check is broken on
> the MFD tree. The primary issue for me is transient failures during
> the merge window.
>
> Rob
- Markuss