Re: [PATCH] perf test: Fix test case 81 on s390x

[John Garry]

On 28/04/2022 14:25, Arnaldo Carvalho de Melo wrote:
> Em Thu, Apr 28, 2022 at 02:28:21PM +0200, Thomas Richter escreveu:
> > perf test -F 81 -v fails on s390x on the linux-next branch.
> > The test case is x86 specific can not be executed on s390x.
> > The test case depends on x86 register names such as
> >
> >    ... | egrep -q 'available registers: AX BX CX DX ....'
>
> Thanks,
>
> Ian, I guess this will break on other !x86 arches as well.

JFYI, arm64 gives on acme perf/core branch @ e0c1b8f9eb this:

john@debian:~/acme/tools/perf$ sudo ./perf test -F 82
 82: perf record tests     :Basic --per-thread mode test
Basic --per-thread mode test [Success]
Register capture test
Register capture test [Skipped missing instruction]
 Ok
john@debian:~/acme/tools/perf$

> Can you
> please take a look?
>
> - Arnaldo
>   
> > Skip this test case on s390x.
> >
> > Output before:
> >   # perf test -F 81
> >   81: perf record tests                       : FAILED!
> >   #
> >
> > Output after:
> >   # perf test -F 81
> >   81: perf record tests                       : Skip
> >   #
> >
> > Fixes: 24f378e66021 ("perf test: Add basic perf record tests")
> > Cc: Ian Rogers <irogers@xxxxxxxxxx>
> > Signed-off-by: Thomas Richter <tmricht@xxxxxxxxxxxxx>
> > ---
> >   tools/perf/tests/shell/record.sh | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> > index cd1cf14259b8..d98f4d4a00e1 100755
> > --- a/tools/perf/tests/shell/record.sh
> > +++ b/tools/perf/tests/shell/record.sh
> > @@ -37,6 +37,8 @@ test_register_capture() {
> >     echo "Register capture test [Success]"
> >   }
> >   
> > +# Test for platform support and return TEST_SKIP
> > +[ $(uname -m) = s390x ] && exit 2
> >   test_per_thread
> >   test_register_capture
> >   exit $err
> > --
> > 2.35.1