Re: [PATCH v2] ASoC: SOF: mediatek: Fix allyesconfig build error

[Pierre-Louis Bossart]

On 4/27/22 02:10, Tinghan Shen wrote:
> ld: sound/soc/sof/mediatek/mt8186/mt8186-clk.o:(.opd+0x18): multiple
> definition of `adsp_clock_on';
> sound/soc/sof/mediatek/mt8195/mt8195-clk.o:(.opd+0x60): first defined
> here
> ld: sound/soc/sof/mediatek/mt8186/mt8186-clk.o: in function
> `.adsp_clock_on':
> 
> ld: sound/soc/sof/mediatek/mt8186/mt8186-clk.o:(.opd+0x30): multiple
> definition of `adsp_clock_off';
> sound/soc/sof/mediatek/mt8195/mt8195-clk.o:(.opd+0x78): first defined
> here
> ld: sound/soc/sof/mediatek/mt8186/mt8186-clk.o: in function
> `.adsp_clock_off':
> 
> ld: sound/soc/sof/mediatek/mt8186/mt8186-loader.o:(.opd+0x0): multiple
> definition of `sof_hifixdsp_boot_sequence';
> sound/soc/sof/mediatek/mt8195/mt8195-loader.o:(.opd+0x0): first defined
> here
> ld: sound/soc/sof/mediatek/mt8186/mt8186-loader.o: in function
> `.sof_hifixdsp_boot_sequence':
> 
> ld: sound/soc/sof/mediatek/mt8186/mt8186-loader.o:(.opd+0x18): multiple
> definition of `sof_hifixdsp_shutdown';
>  sound/soc/sof/mediatek/mt8195/mt8195-loader.o:(.opd+0x18): first defined
> here
> ld: sound/soc/sof/mediatek/mt8186/mt8186-loader.o: in function
> `.sof_hifixdsp_shutdown':
> 
> Fixes: 570c14dc92d5 ("ASoC: SOF: mediatek: Add mt8186 sof fw loader and
> dsp ops")
> Fixes: 210b3ab932f7 ("ASoC: SOF: mediatek: Add mt8186 dsp clock support")
> 
> Signed-off-by: Tinghan Shen <tinghan.shen@xxxxxxxxxxxx>

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>

> ---
> 
> Changes since v1:
> Rebase on Mark's for-next and update "Fixes" commit id
> 
> ---
>  sound/soc/sof/mediatek/mt8186/mt8186-clk.c    |  4 ++--
>  sound/soc/sof/mediatek/mt8186/mt8186-clk.h    |  4 ++--
>  sound/soc/sof/mediatek/mt8186/mt8186-loader.c |  4 ++--
>  sound/soc/sof/mediatek/mt8186/mt8186.c        | 18 +++++++++---------
>  sound/soc/sof/mediatek/mt8186/mt8186.h        |  4 ++--
>  5 files changed, 17 insertions(+), 17 deletions(-)