Re: [PATCH 1/1] kallsyms: add kallsyms_show_value definition in all cases

[Vimal Agrawal]

Hi Maninder,

in sprint_module_info(), we need to take care of mod->init_layout
addresses as well.
Please test the patch against  init symbols.

Vimal

On Wed, Apr 20, 2022 at 8:51 PM Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote:
>
> On Mon, Apr 18, 2022 at 10:04:42AM +0530, Maninder Singh wrote:
> > > What about splitting kallsyms.c into two source files where one
> > > would be always compiled? It would be usable also for the
> > > spring function introduced by
> > > https://lore.kernel.org/r/20220323164742.2984281-1-maninder1.s@xxxxxxxxxxx
> > >
> > > It might be something like kallsyms_full.c and/or kallsyms_tiny.c.
> > >
> >
> > This patch is not taken by Luis yet in module-tetsing branch.
>
> Please resend that patch, as I'm happy to route it in through
> modules-next [0]. I use modules-testing *prior* to pushing to
> modules-next, if 0-day does not complain after about a few days
> then I push to modules-next and this gets merged to linux-next.
>
> You can send that patch and then this one and include in the subject
> something like:
>
> [PATCH modules-next 1/1]
>
> Vimal, I'd like your review of these patches too. And after those
> we can see where your change fits / if it is still needed.
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=modules-next
>
>   Luis