Re: [PATCH v2] dt-bindings: media: mtk-vcodec: Adds encoder power domain property

[Hans Verkuil]

Hi Irui,

I'm merging this patch from Nícolas F. R. A. Prado, which has already been Acked by Rob:

https://patchwork.linuxtv.org/project/linux-media/patch/20220225225854.81038-4-nfraprado@xxxxxxxxxxxxx/

If you still want the other changes you made in this patch merged, then please make
a v3 on top of Nícolas' patch.

Regards,

	Hans

On 27/04/2022 05:31, Irui Wang wrote:
> Adds encoder power domain property.
> 
> Signed-off-by: Irui Wang <irui.wang@xxxxxxxxxxxx>
> ---
> changes compared with v1:
> - set "power-domains" as a non-required property
> 
> The 'make dtbs_check' warnings('mediatek,larb') can be fixed by patch:
> https://patchwork.kernel.org/project/linux-mediatek/list/?series=633993
> ---
>  .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml  | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> index deb5b657a2d5..2d1e0c9bd6ee 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> @@ -41,6 +41,9 @@ properties:
>  
>    assigned-clock-parents: true
>  
> +  power-domains:
> +    maxItems: 1
> +
>    iommus:
>      minItems: 1
>      maxItems: 32
> @@ -132,6 +135,7 @@ examples:
>      #include <dt-bindings/clock/mt8173-clk.h>
>      #include <dt-bindings/memory/mt8173-larb-port.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/power/mt8173-power.h>
>  
>      vcodec_enc_avc: vcodec@18002000 {
>        compatible = "mediatek,mt8173-vcodec-enc";
> @@ -153,6 +157,7 @@ examples:
>        clock-names = "venc_sel";
>        assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>;
>        assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>;
> +      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC>;
>      };
>  
>      vcodec_enc_vp8: vcodec@19002000 {
> @@ -173,4 +178,5 @@ examples:
>        clock-names = "venc_lt_sel";
>        assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>;
>        assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>;
> +      power-domains = <&scpsys MT8173_POWER_DOMAIN_VENC_LT>;
>      };