Re: [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture

[Paul Menzel]

Dear Nick,


Am 26.04.22 um 19:28 schrieb Hawkins, Nick:
> -----Original Message-----
> From: Paul Menzel [mailto:pmenzel@xxxxxxxxxxxxx]
> Sent: Tuesday, April 26, 2022 3:26 AM
> To: Hawkins, Nick <nick.hawkins@xxxxxxx>
> Cc: Verdun, Jean-Marie <verdun@xxxxxxx>; joel@xxxxxxxxx; arnd@xxxxxxxx; openbmc@xxxxxxxxxxxxxxxx; Russell King <linux@xxxxxxxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture

[OT: Maybe use an email program, that does not add an unnecessary header.]

[…]

> > > The GXP is the HPE BMC SoC that is used in the majority of HPE
> > > Generation 10 servers. Traditionally the asic will last multiple
> > > generations of server before being replaced.
>
> > Please mention what kind of documentation (datasheets, …) are available.
>
> Currently there are none available. The only reference I can provide
> will be arm documentation.

Too bad.

> > > In gxp.c we reset the EHCI controller early to boot the asic.
>
> > Why does the EHCI controller need to be reset?
> This functionality was moved into the boot loader. This message is
> stale and needs to be removed. It was necessary for the chip to
> boot.

Understood. Please mention somewhere, what bootloader is used.

> > > Info about SoC:
> > >
> > > HPE GXP is the name of the HPE Soc. This SoC is used to implement many
> > > BMC features at HPE. It supports ARMv7 architecture based on the
> > > Cortex A9 core. It is capable of using an AXI bus to which a memory
> > > controller is attached. It has multiple SPI interfaces to connect boot
> > > flash and BIOS flash. It uses a 10/100/1000 MAC for network
> > > connectivity. It has multiple i2c engines to drive connectivity with a
> > > host infrastructure. The initial patches enable the watchdog and timer
> > > enabling the host to be able to boot.
>
> > Maybe doe that in separate commits?
> Are you asking for me to have this paragraph in the other commits?
> Or perhaps not mention the other patches in this paragraph?

Yes, please move:

> The initial patches enable the watchdog and timer enabling the host
> to be able to boot.

in a cover letter for example.

> > Please reflow the commit message for 75 characters per line.
> I will verify all the lines are under 75 characters.

Please make sure the lines are as long as possible, while being at most 
75 characters long.


Kind regards,

Paul