Re: [PATCH] drm/bridge: ite-it6505: add missing Kconfig option select

From: Neil Armstrong
Date: Tue Apr 26 2022 - 11:29:40 EST


On 26/04/2022 16:15, Fabien Parent wrote:
The IT6505 is using functions provided by the DRM_DP_HELPER driver.
In order to avoid having the bridge enabled but the helper disabled,
let's add a select in order to be sure that the DP helper functions are
always available.

Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx>
---
drivers/gpu/drm/bridge/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 007e5a282f67..2145b08f9534 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -78,6 +78,7 @@ config DRM_ITE_IT6505
tristate "ITE IT6505 DisplayPort bridge"
depends on OF
select DRM_KMS_HELPER
+ select DRM_DP_HELPER
select EXTCON
help
ITE IT6505 DisplayPort bridge chip driver.

http://lore.kernel.org/r/20220403151637.15546-1-rdunlap@xxxxxxxxxxxxx also select DRM_DP_AUX_BUS,
can you check if this is really neaded ?

Neil