Re: [PATCH v1 1/1] iio: temperature: max31865: Make use of device properties

[navin]

On 16.04.22 12:48, Jonathan Cameron wrote:
> On Wed, 13 Apr 2022 21:53:35 +0300
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> > Convert the module to be property provider agnostic and allow
> > it to be used on non-OF platforms.
> This one should call out the addition of missing mod_devicetable.h
> If nothing else comes up I can add that whilst applying.
> Looks fine to me but I'd like to give a little time for
> Navin to comment if they wish.
>
> Jonathan

Looks fine for me. Thanks

Navin

> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/iio/temperature/max31865.c | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/temperature/max31865.c b/drivers/iio/temperature/max31865.c
> > index 86c3f3509a26..e3bb78184c6e 100644
> > --- a/drivers/iio/temperature/max31865.c
> > +++ b/drivers/iio/temperature/max31865.c
> > @@ -12,9 +12,11 @@
> >   #include <linux/delay.h>
> >   #include <linux/err.h>
> >   #include <linux/init.h>
> > +#include <linux/mod_devicetable.h>
> >   #include <linux/module.h>
> >   #include <linux/iio/iio.h>
> >   #include <linux/iio/sysfs.h>
> > +#include <linux/property.h>
> >   #include <linux/spi/spi.h>
> >   #include <asm/unaligned.h>
> >   
> > @@ -305,7 +307,7 @@ static int max31865_probe(struct spi_device *spi)
> >   	indio_dev->channels = max31865_channels;
> >   	indio_dev->num_channels = ARRAY_SIZE(max31865_channels);
> >   
> > -	if (of_property_read_bool(spi->dev.of_node, "maxim,3-wire")) {
> > +	if (device_property_read_bool(&spi->dev, "maxim,3-wire")) {
> >   		/* select 3 wire */
> >   		data->three_wire = 1;
> >   	} else {