RE: [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding

From: Hawkins, Nick
Date: Tue Apr 26 2022 - 09:22:47 EST




-----Original Message-----
From: Rob Herring [mailto:robh@xxxxxxxxxx]
Sent: Monday, April 25, 2022 5:05 PM
To: Hawkins, Nick <nick.hawkins@xxxxxxx>
Cc: Verdun, Jean-Marie <verdun@xxxxxxx>; joel@xxxxxxxxx; arnd@xxxxxxxx; openbmc@xxxxxxxxxxxxxxxx; Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>; Guenter Roeck <linux@xxxxxxxxxxxx>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; linux-watchdog@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding

(...)

> How is this h/w controlled? I'm guessing it's part of the timer? If so, you don't need this node. A single node can implement multiple functions.

It is associated with the timer because of the shared register set. Based on feedback from Krzysztof I need to create a child node for gxp-timer. I therefore will remove this file and move gxp-wdt to the hpe,gxp-timer.yaml as a child node.

Thank you for the feedback.

-Nick Hawkins