Re: [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards

From: Krzysztof Kozlowski
Date: Tue Apr 26 2022 - 02:45:14 EST


On 26/04/2022 08:35, Oleksij Rempel wrote:
> On Mon, Apr 25, 2022 at 04:06:45PM +0200, Krzysztof Kozlowski wrote:
>> On 25/04/2022 15:53, Krzysztof Kozlowski wrote:
>>> On 25/04/2022 15:28, Oleksij Rempel wrote:
>>>> This boards are based on STM32MP151AAD3 and use 10BaseT1L for
>>>> communication.
>>>>
>>>> - PRTT1C - 10BaseT1L switch
>>>> - PRTT1S - 10BaseT1L CO2 sensor board
>>>> - PRTT1A - 10BaseT1L multi functional controller
>>>>
>>>> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
>>>> ---
>>>
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>
>> Although the order is still messed up. I through you will move the entry
>> just slightly up, not to the beginning, so maybe just rebase on top of:
>> https://lore.kernel.org/all/20220425140436.332467-1-krzysztof.kozlowski@xxxxxxxxxx/
>
> I put it according to the SoC version. st,stm32mp151 would be the first
> entry before stm32mp153. What order do you prefer, where should I put my
> boards?

153 is defined lower. The first entry in the file is a trap. :)


Best regards,
Krzysztof