Re: [PATCH v2 1/1] dt-bindings: nvmem: mediatek: Convert mtk-efuse binding to YAML

From: Krzysztof Kozlowski
Date: Tue Apr 26 2022 - 02:31:31 EST


On 26/04/2022 08:23, allen-kh.cheng wrote:
>>> +properties:
>>> + compatible:
>>> + oneOf:
>>> + - enum:
>>> + - mediatek,mt8173-efuse
>>> + - mediatek,efuse
>>
>> Still no changes...
>>
>
> I just want to confirm again.
>
> "Generic compatibles should not be used standalone"
>
> It seems we should remove mediatek,efuse and keep "mediatek,mt8173-
> efuse"in binding. have I got that right?

You should comment for which chipsets this compatible is and add a
deprecated:true. In such case it cannot be part of enum but separate
item in this oneOf.


Best regards,
Krzysztof