Re: linux-next: build warning after merge of the imx-mxs tree

From: Shawn Guo
Date: Mon Apr 25 2022 - 21:16:15 EST


On Tue, Apr 26, 2022 at 10:06:59AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the imx-mxs tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> arch/arm/boot/dts/ls1021a-iot.dts:150.3-26: Warning (clocks_property): /soc/i2c@2180000/audio-codec@2a:clocks: cell 1 is not a phandle reference
> arch/arm/boot/dts/ls1021a-iot.dts:144.27-151.4: Warning (clocks_property): /soc/i2c@2180000/audio-codec@2a: Missing property '#clock-cells' in node /soc/interrupt-controller@1400000 or bad phandle (referred from clocks[1])
>
> Introduced by commit
>
> 23f550d5f7f6 ("ARM: dts: Add initial LS1021A IoT board dts support")

Changming,

I fixed it up with the following change. Let me know if you disagree.

diff --git a/arch/arm/boot/dts/ls1021a-iot.dts b/arch/arm/boot/dts/ls1021a-iot.dts
index bdb7186f3590..66bcdaf4b6f9 100644
--- a/arch/arm/boot/dts/ls1021a-iot.dts
+++ b/arch/arm/boot/dts/ls1021a-iot.dts
@@ -147,7 +147,7 @@ sgtl5000: audio-codec@2a {
reg = <0x2a>;
VDDA-supply = <&reg_3p3v>;
VDDIO-supply = <&reg_2p5v>;
- clocks = <&sys_mclk 1>;
+ clocks = <&sys_mclk>;
};

max1239: adc@35 {