Re: [PATCH v5 0/2] selftests/resctrl: Print a message if the result of MBM&CMT tests is failed on Intel CPU

[Shuah Khan]

On 4/25/22 3:19 PM, Reinette Chatre wrote:
> Hi Shuah,
>
> On 3/29/2022 8:37 AM, Shuah Khan wrote:
> > On 3/23/22 2:09 AM, Shaopeng Tan wrote:
> > > Hello,
> > >
> > > The aim of this series is to print a message to let users know a possible
> > > cause of failure, if the result of MBM&CMT tests is failed on Intel CPU.
> > > In order to detect Intel vendor, I extended AMD vendor detect function.
> > >
> > > Difference from v4:
> > > - Fixed the typos.
> > > - Changed "get_vendor() != ARCH_AMD" to "get_vendor() == ARCH_INTEL".
> > > - Reorder the declarations based on line length from longest to shortest.
> > > https://lore.kernel.org/lkml/20220316055940.292550-1-tan.shaopeng@xxxxxxxxxxxxxx/ [PATCH v4]
> > >
> > > This patch series is based on v5.17.
> > >
> > > Shaopeng Tan (2):
> > >     selftests/resctrl: Extend CPU vendor detection
> > >     selftests/resctrl: Print a message if the result of MBM&CMT tests is
> > >       failed on Intel CPU
> > >
> > >    tools/testing/selftests/resctrl/cat_test.c    |  2 +-
> > >    tools/testing/selftests/resctrl/resctrl.h     |  5 ++-
> > >    .../testing/selftests/resctrl/resctrl_tests.c | 45 +++++++++++++------
> > >    tools/testing/selftests/resctrl/resctrlfs.c   |  2 +-
> > >    4 files changed, 37 insertions(+), 17 deletions(-)
> >
> > I can queue this up for Linux 5.18-rc2. Thanks for fixing the error
> > path with clear messages for failures.
>
> Is this perhaps still in your queue for consideration? I peeked at the
> branches within the kselftest repo but could not find it merged yet.
> If things are tightened for fixes it would be welcome as v5.19 material
> also.
>
> Thank you very much

Thanks for the ping. The changes are a bit more extensive for a fix based
on my review comments. I queued these two in linux-kselftest next branch
for 5.19-rc1.

thanks,
-- Shuah