Re: Re: [PATCH] bus: sunxi-rsb: Fix the return value of sunxi_rsb_device_create()

[Jernej Škrabec]

Dne sobota, 23. april 2022 ob 21:39:45 CEST je Samuel Holland napisal(a):
> On 4/21/22 9:35 AM, Christophe JAILLET wrote:
> > This code is really spurious.
> > It always returns an ERR_PTR, even when err is known to be 0 and calls
> > put_device() after a successful device_register() call.
> > 
> > It is likely that the return statement in the normal path is missing.
> > Add 'return rdev;' to fix it.
> 
> Thanks for the patch. This definitely looks to be the case.
> 
> > Fixes: d787dcdb9c8f ("bus: sunxi-rsb: Add driver for Allwinner Reduced 
Serial Bus")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> 
> Reviewed-by: Samuel Holland <samuel@xxxxxxxxxxxx>
> Tested-by: Samuel Holland <samuel@xxxxxxxxxxxx>
> 

Applied to sunxi/fixes-for-5.18, thanks!

Best regards,
Jernej