Re: [PATCH 4/4] dt-bindings: media: mtk-vcodec: Add encoder power domain property

From: Rob Herring
Date: Mon Apr 25 2022 - 12:37:41 EST


On Thu, Apr 21, 2022 at 11:51:11AM +0800, Allen-KH Cheng wrote:
> From: Irui Wang <irui.wang@xxxxxxxxxxxx>
>
> Add encoder power domain property
>
> Signed-off-by: Irui Wang <irui.wang@xxxxxxxxxxxx>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@xxxxxxxxxxxx>
> ---
> .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> index e7b65a91c92c..de2df6c6352c 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> @@ -41,6 +41,9 @@ properties:
>
> assigned-clock-parents: true
>
> + power-domains:
> + maxItems: 1
> +
> iommus:
> minItems: 1
> maxItems: 32
> @@ -74,6 +77,7 @@ required:
> - iommus
> - assigned-clocks
> - assigned-clock-parents
> + - power-domains

New properties can't be required as that's an ABI change unless there is
some explanation why it is okay/necessary.

Rob