Re: [PATCH] irqchip/sun6i-r: Use NULL for chip_data

From: Jernej Škrabec
Date: Sun Apr 24 2022 - 15:55:32 EST


Dne nedelja, 24. april 2022 ob 19:39:51 CEST je Samuel Holland napisal(a):
> sparse complains about using an integer as a NULL pointer.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>

Reviewed-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>

Best regards,
Jernej

> ---
>
> drivers/irqchip/irq-sun6i-r.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-sun6i-r.c b/drivers/irqchip/irq-sun6i-r.c
> index 4cd3e533740b..a01e44049415 100644
> --- a/drivers/irqchip/irq-sun6i-r.c
> +++ b/drivers/irqchip/irq-sun6i-r.c
> @@ -249,11 +249,13 @@ static int sun6i_r_intc_domain_alloc(struct irq_domain
*domain,
> for (i = 0; i < nr_irqs; ++i, ++hwirq, ++virq) {
> if (hwirq == nmi_hwirq) {
> irq_domain_set_hwirq_and_chip(domain, virq,
hwirq,
> -
&sun6i_r_intc_nmi_chip, 0);
> +
&sun6i_r_intc_nmi_chip,
> + NULL);
> irq_set_handler(virq,
handle_fasteoi_ack_irq);
> } else {
> irq_domain_set_hwirq_and_chip(domain, virq,
hwirq,
> -
&sun6i_r_intc_wakeup_chip, 0);
> +
&sun6i_r_intc_wakeup_chip,
> + NULL);
> }
> }
>
> --
> 2.35.1
>
>