Re: [PATCH v10 06/14] mm: multi-gen LRU: minimal implementation

From: Barry Song
Date: Fri Apr 15 2022 - 06:16:07 EST


On Fri, Apr 15, 2022 at 9:40 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, 14 Apr 2022 14:36:03 -0600 Yu Zhao <yuzhao@xxxxxxxxxx> wrote:
>
> > > or it is only something
> > > meaningful for the internal code?
> >
> > This is how swappiness is interpreted.
> >
> > > if so, can we rename it to
> > > something else? otherwise, it is quite confusing.
> >
> > Feel free to suggest something.
>
> It is confusing, swap_preference?

seems to be much better. might also be worth using MACRO to replace those
1, 200, 0 magic numbers to tell readers the exact meaning?

>
>
Thanks
Barry