Re: [RFC PATCH 6/6] Drivers: hv: vmbus: Refactor the ring-buffer iterator functions

From: Andrea Parri
Date: Fri Apr 15 2022 - 03:00:44 EST


> > @@ -470,7 +471,6 @@ struct vmpacket_descriptor *hv_pkt_iter_first_raw(struct
> > vmbus_channel *channel)
> >
> > return (struct vmpacket_descriptor *)(hv_get_ring_buffer(rbi) + rbi-
> > >priv_read_index);
> > }
> > -EXPORT_SYMBOL_GPL(hv_pkt_iter_first_raw);
>
> Does hv_pkt_iter_first_raw() need to be retained at all as a
> separate function? I think after these changes, the only caller
> is hv_pkt_iter_first(), in which case the code could just go
> inline in hv_pkt_iter_first(). Doing that combining would
> also allow the elimination of the duplicate call to
> hv_pkt_iter_avail().

Good point. Will do.

Thanks,
Andrea