Re: [PATCH 1/2] dt-bindings: usb: tps6598x: Make the interrupts property optional

[Roger Quadros]

Hi,

On 14/04/2022 11:31, Aswath Govindraju wrote:
> Support for polling has been added in the driver, which will be used by
> default if interrupts property is not populated. Therefore, remove
> interrupts and interrupt-names from the required properties and add a note
> under interrupts property describing the above support in driver.
> 
> Suggested-by: Roger Quadros <rogerq@xxxxxxxxxx>

I did not suggest to make interrupts optional by default.

What I suggested was that if a DT property exists to explicitly
indicate polling mode then interrupts are not required.

> Signed-off-by: Aswath Govindraju <a-govindraju@xxxxxx>
> ---
>  Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> index a4c53b1f1af3..1c4b8c6233e5 100644
> --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> @@ -25,6 +25,8 @@ properties:
>  
>    interrupts:
>      maxItems: 1
> +    description:
> +      If interrupts are not populated then by default polling will be used.
>  
>    interrupt-names:
>      items:
> @@ -33,8 +35,6 @@ properties:
>  required:
>    - compatible
>    - reg
> -  - interrupts
> -  - interrupt-names
>  
>  additionalProperties: true
>  

cheers,
-roger