Re: [PATCH 0/7] staging: r8188eu: fix and clean up some firmware code

From: Larry Finger
Date: Thu Apr 14 2022 - 12:08:07 EST


On 4/14/22 03:38, Michael Straube wrote:
This series fixes wrong size of struct rt_firmware_hdr in the first
patch and does some cleanups in rtl8188e_firmware_download() in the
other patches.

Tested on x86_64 with Inter-Tech DMG-02.

Michael Straube (7):
staging: r8188eu: fix struct rt_firmware_hdr
staging: r8188eu: clean up comments in struct rt_firmware_hdr
staging: r8188eu: rename fields of struct rt_firmware_hdr
staging: r8188eu: use sizeof instead of hardcoded firmware header size
staging: r8188eu: remove variables from rtl8188e_firmware_download()
staging: r8188eu: always log firmware info
staging: r8188eu: check firmware header existence before access

Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> for 2/7 through 5/7. Patch 1/7 has a typo in the commit message, and I have objection to the logging changes in 6/7 and 7/7.

Larry