Re: [PATCH 1/7] staging: r8188eu: fix struct rt_firmware_hdr

From: Larry Finger
Date: Thu Apr 14 2022 - 12:00:00 EST


On 4/14/22 03:38, Michael Straube wrote:
The second issue is that the u16 and u32 fields sould be __le16 and
__le32.

Change the field Rsvd1 to u8 and the u16, u32 fileds to __le16, __le32.

There is a typo here.

Note that the various RsvdN fields are just reserving space and will never be referenced, thus it does not matter if they are u32 or __le32. It is OK to change them, but it is not wrong to leave them the way they are.

Larry