RE: staging: r8188eu: struct rt_firmware_header issues

From: David Laight
Date: Thu Apr 14 2022 - 06:14:34 EST


From: Michael Straube
> Sent: 14 April 2022 11:08
>
> On 4/14/22 10:41, David Laight wrote:
> > From: Michael Straube
> >> Sent: 13 April 2022 20:42
> >>
> >> On 4/13/22 18:27, Michael Straube wrote:
> >>> Hi all,
> >>>
> >>> I think the rt_firmware_hdr structure in rtw_fw.c has some issues.
> >>>
> >>>
> >>> struct rt_firmware_hdr {
> >>>     /*  8-byte alinment required */
> >
> > Probably need an __aligned(8) at the bottom then?
>
> I don't see any reason why this is needed. Do I miss something?

Dunno, the comment might be wrong.

david

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)