Re: [PATCH v1 2/3] iio: ABI: adc: ad4130: document filter_mode{,_available}

[Cosmin Tanislav]

On 4/13/22 17:51, Andy Shevchenko wrote:
> On Wed, Apr 13, 2022 at 4:17 PM Cosmin Tanislav <demonsingur@xxxxxxxxx> wrote:
>
> It's good you provided documentation, but I think the part "ABI:" is
> not needed in the Subject.

Then I guess I could merge this patch into the driver patch?

> > AD4130-8 is an ultra-low power, high precision,
> > measurement solution for low bandwidth battery
> > operated applications.
> >
> > The fully integrated AFE (Analog Front-End)
> > includes a multiplexer for up to 16 single-ended
> > or 8 differential inputs, PGA (Programmable Gain
> > Amplifier), 24-bit Sigma-Delta ADC, on-chip
> > reference and oscillator, selectable filter
> > options, smart sequencer, sensor biasing and
> > excitation options, diagnostics, and a FIFO
> > buffer.
>
> Indentation issue as per patch 1.
>
> ...
>
> > +               Set the filter mode of the differential channel. When the filter
> > +               mode changes, the in_voltageY-voltageZ_sampling_frequency and
> > +               in_voltageY-voltageZ_sampling_frequency_available attributes
> > +               might also change to accomodate the new filter mode.
>
> accommodate
>
> > +               If the current sampling frequency is out of range for the new
> > +               filter mode, the sampling frequency will be changed to the
> > +               closest valid one.