Re: [PATCH 04/18] objtool: Print data address for "!ENDBR" data warnings

From: Peter Zijlstra
Date: Thu Apr 14 2022 - 03:37:01 EST


On Wed, Apr 13, 2022 at 04:19:39PM -0700, Josh Poimboeuf wrote:
> When a "!ENDBR" warning is reported for a data section, objtool just
> prints the text address of the relocation target twice, without giving
> any clues about the location of the original data reference:
>
> vmlinux.o: warning: objtool: dcbnl_netdevice_event()+0x0: .text+0xb64680: data relocation to !ENDBR: dcbnl_netdevice_event+0x0
>
> Instead, print the address of the data reference, in addition to the
> address of the relocation target.
>
> vmlinux.o: warning: objtool: dcbnl_nb+0x0: .data..read_mostly+0xe260: data relocation to !ENDBR: dcbnl_netdevice_event+0x0

Duh yes!