Re: [PATCH net] net: dsa: realtek: don't parse compatible string for RTL8366S

From: Andrew Lunn
Date: Tue Apr 12 2022 - 13:39:51 EST


On Tue, Apr 12, 2022 at 05:57:49PM +0200, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
>
> This switch is not even supported, but if someone were to actually put
> this compatible string "realtek,rtl8366s" in their device tree, they
> would be greeted with a kernel panic because the probe function would
> dereference NULL. So let's just remove it.
>
> Link: https://lore.kernel.org/all/CACRpkdYdKZs0WExXc3=0yPNOwP+oOV60HRz7SRoGjZvYHaT=1g@xxxxxxxxxxxxxx/
> Signed-off-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew