Re: [PATCH 2/2] x86/unwind/orc: Fix address check size for deref_stack_iret_regs

From: Peter Zijlstra
Date: Tue Apr 12 2022 - 07:09:38 EST


On Tue, Apr 12, 2022 at 10:40:04AM +0300, Dmitry Monakhov wrote:
> For historical reasons we check only IRET_FRAME_OFFSET, but this check
> is no longer valid because we also access regs->sp field which is
> located beyond IRET_FRAME, so it is reasonable to validate full structure.

Uuuh, what? IRET frame is:

ss, sp, flags, cs, ip

that very much includes sp.