Re: [PATCH] hsi: clients: remove duplicate assignment

[Sebastian Reichel]

Hi,

On Thu, Mar 31, 2022 at 05:07:38AM -0700, Qing Wang wrote:
> From: Wang Qing <wangqing@xxxxxxxx>
> 
> netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed,
> no need to repeat assignment.
> 
> Signed-off-by: Wang Qing <wangqing@xxxxxxxx>
> ---

Thanks, queued.

-- Sebastian

>  drivers/hsi/clients/ssi_protocol.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
> index 21f11a5..7aacb19
> --- a/drivers/hsi/clients/ssi_protocol.c
> +++ b/drivers/hsi/clients/ssi_protocol.c
> @@ -796,7 +796,6 @@ static void ssip_rx_strans(struct hsi_client *cl, u32 cmd)
>  		dev_err(&cl->device, "No memory for rx skb\n");
>  		goto out1;
>  	}
> -	skb->dev = ssi->netdev;
>  	skb_put(skb, len * 4);
>  	msg = ssip_alloc_data(ssi, skb, GFP_ATOMIC);
>  	if (unlikely(!msg)) {
> -- 
> 2.7.4
>

Attachment: signature.asc
Description: PGP signature