Re: [PATCH v2] slimbus: qcom: Fix IRQ check in qcom_slim_probe

[Srinivas Kandagatla]

On 01/03/2022 06:14, Miaoqian Lin wrote:
> platform_get_irq() returns non-zero IRQ number on success,
> negative error number on failure.
> And the doc of platform_get_irq() provides a usage example:
>
>      int irq = platform_get_irq(pdev, 0);
>      if (irq < 0)
>          return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver")
> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>

Applied thanks,

--srini
> ---
> changes in v2:
> - use more precise expression in commit message.
> ---
>   drivers/slimbus/qcom-ctrl.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
> index f04b961b96cd..ec58091fc948 100644
> --- a/drivers/slimbus/qcom-ctrl.c
> +++ b/drivers/slimbus/qcom-ctrl.c
> @@ -510,9 +510,9 @@ static int qcom_slim_probe(struct platform_device *pdev)
>   	}
>   
>   	ctrl->irq = platform_get_irq(pdev, 0);
> -	if (!ctrl->irq) {
> +	if (ctrl->irq < 0) {
>   		dev_err(&pdev->dev, "no slimbus IRQ\n");
> -		return -ENODEV;
> +		return ctrl->irq;
>   	}
>   
>   	sctrl = &ctrl->ctrl;