Re: [PATCH v2] staging: wfx: use container_of() to get vif

From: Jaehee Park
Date: Tue Apr 12 2022 - 00:18:30 EST


On Sat, Apr 09, 2022 at 04:07:12PM +0200, Jérôme Pouiller wrote:
> On Friday 8 April 2022 07:44:24 CEST Stefano Brivio wrote:
> > On Fri, 8 Apr 2022 06:45:52 +0200 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > On Thu, Apr 07, 2022 at 11:23:49PM -0400, Jaehee Park wrote:
> > > >
> > > > [...]
> > > >
> > > > @@ -61,7 +63,6 @@ struct wfx_dev {
> > > >
> > > > struct wfx_vif {
> > > > struct wfx_dev *wdev;
> > > > - struct ieee80211_vif *vif;
> > >
> > > You need to test this on real hardware. For an outreachy-first-task,
> > > this is not a good one at all.
> >
> > We discussed about this on the outreachy list, and I suggested, as
> > Jaehee also mentioned, that maybe somebody (Jérôme?) with the hardware
> > could give it a try.
> >
> > It looks a bit difficult but it also looks almost correctly done now. :)
>
> Absolutely.
>
> I will test it once the various comments will be fixed.
>
>
> --
> Jérôme Pouiller
>
>
I just wanted to update and let you know that I mailed a new patch v3 just now.
Thanks!