Re: [PATCH 4/4] ARM: at91: pm: use kernel documentation style

From: kernel test robot
Date: Mon Apr 11 2022 - 17:46:04 EST


Hi Claudiu,

I love your patch! Perhaps something to improve:

[auto build test WARNING on soc/for-next]
[also build test WARNING on v5.18-rc2 next-20220411]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Claudiu-Beznea/ARM-at91-pm-add-quirks-for-ethernet/20220411-191956
base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
config: arm-sama7_defconfig (https://download.01.org/0day-ci/archive/20220412/202204120552.PLev1dS4-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c6e83f560f06cdfe8aa47b248d8bdc58f947274b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/intel-lab-lkp/linux/commit/0d5dd0bc2c021263d5e0c3b27fb073830ef4aa54
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Claudiu-Beznea/ARM-at91-pm-add-quirks-for-ethernet/20220411-191956
git checkout 0d5dd0bc2c021263d5e0c3b27fb073830ef4aa54
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> arch/arm/mach-at91/pm.c:62: warning: expecting prototype for struct at91_pm_sfrbu_offsets. Prototype was for struct at91_pm_sfrbu_regs instead


vim +62 arch/arm/mach-at91/pm.c

f19dd1df9e71da Claudiu Beznea 2021-04-15 50
0d5dd0bc2c0212 Claudiu Beznea 2022-04-11 51 /**
0d5dd0bc2c0212 Claudiu Beznea 2022-04-11 52 * struct at91_pm_sfrbu_offsets - registers mapping for SFRBU
ac809e7879b156 Claudiu Beznea 2021-08-30 53 * @pswbu: power switch BU control registers
ac809e7879b156 Claudiu Beznea 2021-08-30 54 */
ac809e7879b156 Claudiu Beznea 2021-08-30 55 struct at91_pm_sfrbu_regs {
ac809e7879b156 Claudiu Beznea 2021-08-30 56 struct {
ac809e7879b156 Claudiu Beznea 2021-08-30 57 u32 key;
ac809e7879b156 Claudiu Beznea 2021-08-30 58 u32 ctrl;
ac809e7879b156 Claudiu Beznea 2021-08-30 59 u32 state;
ac809e7879b156 Claudiu Beznea 2021-08-30 60 u32 softsw;
ac809e7879b156 Claudiu Beznea 2021-08-30 61 } pswbu;
ac809e7879b156 Claudiu Beznea 2021-08-30 @62 };
ac809e7879b156 Claudiu Beznea 2021-08-30 63

--
0-DAY CI Kernel Test Service
https://01.org/lkp