Re: [PATCH net-next v7 2/2] net: ethernet: Add driver for Sunplus SP7021

From: Jakub Kicinski
Date: Mon Apr 11 2022 - 16:35:06 EST


On Tue, 12 Apr 2022 01:11:28 +0800 Wells Lu wrote:
> +config NET_VENDOR_SUNPLUS
> + bool "Sunplus devices"
> + default y
> + depends on ARCH_SUNPLUS || COMPILE_TEST
> + help
> + If you have a network (Ethernet) card belonging to this
> + class, say Y here.
> +
> + Note that the answer to this question doesn't directly
> + affect the kernel: saying N will just cause the configurator
> + to skip all the questions about Sunplus cards. If you say Y,
> + you will be asked for your specific card in the following
> + questions.
> +
> +if NET_VENDOR_SUNPLUS
> +
> +config SP7021_EMAC
> + tristate "Sunplus Dual 10M/100M Ethernet devices"
> + depends on SOC_SP7021 || COMPILE_TEST
> + select PHYLIB
> + select PINCTRL_SPPCTL
> + select COMMON_CLK_SP7021
> + select RESET_SUNPLUS
> + select NVMEM_SUNPLUS_OCOTP
> + help
> + If you have Sunplus dual 10M/100M Ethernet devices, say Y.
> + The network device creates two net-device interfaces.
> + To compile this driver as a module, choose M here. The
> + module will be called sp7021_emac.

x86 allmodconfig is not happy about it:

WARNING: unmet direct dependencies detected for PINCTRL_SPPCTL
Depends on [n]: PINCTRL [=y] && SOC_SP7021 && OF [=y] && HAS_IOMEM [=y]
Selected by [m]:
- SP7021_EMAC [=m] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_SUNPLUS [=y] && (SOC_SP7021 || COMPILE_TEST [=y])

Please wait at least 24h before reposting.