Re: [PATCH 1/1] iommu/vt-d: Change return type of dmar_insert_one_dev_info()

From: Christoph Hellwig
Date: Mon Apr 11 2022 - 10:26:13 EST


On Sat, Apr 09, 2022 at 09:30:06PM +0800, Lu Baolu wrote:
> The dmar_insert_one_dev_info() returns the pass-in domain on success and
> NULL on failure. This doesn't make much sense. Change it to an integer.

Looks sensibel. Why not also merge it with domain_add_dev_info while
you're at it?