Re: [PATCH v8 05/20] cachefiles: implement on-demand read

[David Howells]

Jeffle Xu <jefflexu@xxxxxxxxxxxxxxxxx> wrote:

>  	/*
>  	 * Uninstall anon_fd to the cachefiles object, so that no further
>  	 * associated requests will get enqueued.
>  	 */

"Uninstall anon_fd from..."?

> +static int init_read_req(struct cachefiles_req *req, void *private)

Prefix with "cachefiles_" please (or "cachefiles_ondemand_").

David