[PATCH] firewire: Fix using uninitialized value

From: cgel . zte
Date: Mon Apr 11 2022 - 06:52:15 EST


From: Lv Ruyi <lv.ruyi@xxxxxxxxxx>

If data is null, request->data wouldn't be assigned value. It is random
value, but we use it in handle_exclusive_region_request() and
handle_fcp_region_request() later. Fix the bug by initializing it.

Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
Signed-off-by: Lv Ruyi <lv.ruyi@xxxxxxxxxx>
---
drivers/firewire/core-transaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firewire/core-transaction.c b/drivers/firewire/core-transaction.c
index e12a0a4c33f7..16ecfa7da177 100644
--- a/drivers/firewire/core-transaction.c
+++ b/drivers/firewire/core-transaction.c
@@ -778,7 +778,7 @@ static struct fw_request *allocate_request(struct fw_card *card,
return NULL;
}

- request = kmalloc(sizeof(*request) + length, GFP_ATOMIC);
+ request = kzalloc(sizeof(*request) + length, GFP_ATOMIC);
if (request == NULL)
return NULL;

--
2.25.1