Re: [Patch v6 2/4] memory: tegra: Add MC error logging on tegra186 onward

[Ashish Mhetre]

On 4/10/2022 8:25 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 06.04.2022 08:24, Ashish Mhetre пишет:
> >        /* clear interrupts */
> > -     mc_writel(mc, status, MC_INTSTATUS);
> > +     if (mc->soc->num_channels) {
> > +             u32 status_chan_bit;
> > +
> > +             mc_ch_writel(mc, channel, status, MC_INTSTATUS);
> > +             status_chan_bit = BIT(channel) << mc->soc->status_reg_chan_shift;
>
> s/status_reg_chan_shift/global_intstatus_channel_shift/
Okay, I'll update in v7.

> > +             mc_ch_writel(mc, MC_BROADCAST_CHANNEL, status_chan_bit, MC_GLOBAL_INTSTATUS);
> and maybe add a one-line mc_channel_to_global_intstatus(mc, channel) helper
>
> mc_ch_writel(mc, MC_BROADCAST_CHANNEL,
>               mc_channel_to_global_intstatus(mc, chan),
>               MC_GLOBAL_INTSTATUS);
Okay, I'll add helper for getting status bit from channel and use it.

> > +     } else
> > +             mc_writel(mc, status, MC_INTSTATUS);
>
> Missing braces after "else", "./scripts/checkpatch.pl --strict" should warn about this.
I didn't run checkpatch.pl with "--strict". I will run from next time
and address this.

> Otherwise this patch looks okay at a quick glance.

Thanks Dmitry. I'll address these comments.