Re: [PATCH v2] PM: opp: Fix NULL pointer exception on a v2 table combined with v1 opps

From: Viresh Kumar
Date: Sun Apr 10 2022 - 22:49:25 EST


On 04-04-22, 14:37, Krzysztof Kozlowski wrote:
> dev_pm_opp_add() adds a v1 OPP.

That's not correct, it adds a simpler version of OPP and doesn't
support complex types. A opp v2 table with just freq and voltage
should be supported by dev_pm_opp_add() and we shouldn't disallow it.

I think all we need here is a couple of checks to make sure the
earlier OPPs don't have anything which the new OPP can't support. For
example checking required-opps field, etc.

--
viresh