Re: [PATCH RESEND v3 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding

From: Andrew Jeffery
Date: Sun Apr 10 2022 - 20:16:12 EST


Hi Dylan,

On Thu, 7 Apr 2022, at 17:27, Dylan Hung wrote:
> The AST2600 MDIO bus controller has a reset control bit and must be
> deasserted before manipulating the MDIO controller. By default, the
> hardware asserts the reset so the driver only need to deassert it.
>
> Regarding to the old DT blobs which don't have reset property in them,
> the reset deassertion is usually done by the bootloader so the reset
> property is optional to work with them.
>
> Signed-off-by: Dylan Hung <dylan_hung@xxxxxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
> .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> index 1c88820cbcdf..7f43b4fe86a3 100644
> --- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> @@ -20,10 +20,14 @@ allOf:
> properties:
> compatible:
> const: aspeed,ast2600-mdio
> +
> reg:
> maxItems: 1
> description: The register range of the MDIO controller instance
>
> + resets:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> @@ -39,6 +43,7 @@ examples:
> reg = <0x1e650000 0x8>;
> #address-cells = <1>;
> #size-cells = <0>;
> + resets = <&syscon 35>;

This is just the example but we should probably have it do the
canonical thing and use ASPEED_RESET_MII from
include/dt-bindings/clock/ast2600-clock.h

Andrew