Re: [PATCH 05/18] MIPS: DTS: jz4780: fix pinctrl as reported by dtbscheck

From: H. Nikolaus Schaller
Date: Sat Apr 09 2022 - 10:06:10 EST




> Am 09.04.2022 um 16:00 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>:
>
> On 09/04/2022 15:57, H. Nikolaus Schaller wrote:
>>
>>
>>> Am 09.04.2022 um 15:46 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>:
>>>
>>> On 09/04/2022 15:41, H. Nikolaus Schaller wrote:
>>>>>
>>>>> No. I ask you to fix all pin-controller cases, for entire MIPS, not just
>>>>> one.
>>>>
>>>> Oops. Nope. I am a volunteer and neither your employee nor slave.
>>>
>>> No one thinks differently and I am sorry that you felt it. Please accept
>>> my apologies, if you get different impression. You understand though the
>>> meaning of word "ask for something" and "order something" (the latter
>>> which I did not use).
>>>
>>> I just asked.
>>
>> Ok. Maybe english is not our mother language and we sometimes don't
>> get the nuances right. Sorry if I understood that wrongly.
>>
>> At least I now understand what you did suggest.
>
> Yeah, probably I did not express my thoughts correctly.
>
> I would like to state that I appreciate your work and I think it is
> important, even if I do not express it correctly. Please accept my
> apologies if I am bit harsh or impolite. That's not my intention.

I also was a little harsh in my response. Sorry again.

>
>>
>> Doing the same change for treewide MIPS is beyond my capabilities since
>> I can't easily test any compile setup. So far I only compile for CI20 and
>> as far as I know every machine still needs its own config for MIPS
>> (haven't checked recently). So I am not even sure if dtbscheck tells me
>> all locations.
>
>
> OK, fair enough.
>
>
> Best regards,
> Krzysztof

Anyways thank you very much for your reviews and sharing comments.

As far as I see there are only the jz4780-nemc/simple-mfd and the snps,dwc2/jz4780-otg
issues really unsolved while the others are more cosmetics.

Let's see how these settle.

BR and thanks,
Nikolaus