Re: [PATCH 07/18] MIPS: DTS: jz4780: fix otg node as reported by dtbscheck

From: H. Nikolaus Schaller
Date: Sat Apr 09 2022 - 09:32:43 EST




> Am 09.04.2022 um 15:15 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>:
>
> On 09/04/2022 15:05, H. Nikolaus Schaller wrote:
>>>
>>> This looks wrong, the block usually should have a specific compatible.
>>> Please mention why it does not.
>>
>> Well, I did not even have that idea that it could need an explanation.
>>
>> There is no "ingenic,jz4780-otg" and none is needed here to make it work.
>
> Make it work in what terms? We talk about hardware description, right?

Yes.

>
>>
>> Therefore the generic "snps,dwc2" is sufficient.
>
> No, you are mixing now driver behavior (is sufficient) with hardware
> description.

No. "snps,dwc2" is a hardware description for a licensed block.
Not a driver behavior.

> Most of licensed blocks require the specific compatible to
> differentiate it.

If there is a need to differentiate.