Re: [PATCH 05/18] MIPS: DTS: jz4780: fix pinctrl as reported by dtbscheck

From: Krzysztof Kozlowski
Date: Sat Apr 09 2022 - 09:27:14 EST


On 09/04/2022 15:22, H. Nikolaus Schaller wrote:
>>
>> What does that mean? One cannot create multiple patches and apply them?
>
> This patch set was created by some automatic scripts. And they produce one patch
> per group of warnings.
>
> But here you ask me to merge 4 unrelated topics into a single one.
>
> Or do you mean something else?

You can edit a commit, right? git commit --amend? So where is the problem?

>
>>
>>> And they are not related. Every one is based on a different .yaml
>>> schema file.
>>
>> Which does not matter, because the name of the node does not matter. We
>> enforce it in schema to makes things organized and easier in testing.
>> This does not fix any real problem, just the problem we created by
>> ourselves with schema.
>>
>>>
>>> That in all cases the result looks similar comes from similar
>>> requirements by the schemata and has no inherent connection.
>>
>> All schemas will require it, won't they? The same for arm...
>
> We may be talking about different things here.
>
> My understanding:
> you ask me to merge 5/18, 8/18, 9/18, 12/18 because they contain "controller" in the node-name.
>
> Right? If not then we must clarify that first.

No. I ask you to fix all pin-controller cases, for entire MIPS, not just
one.

And in one month one more. And then again one more.


Best regards,
Krzysztof