Re: [PATCH 13/18] dt-bindings: fix jz4780-nemc issue as reported by dtbscheck

[Paul Cercueil]

Hi Krzysztof,

Le sam., avril 9 2022 at 13:26:25 +0200, Krzysztof Kozlowski 
<krzysztof.kozlowski@xxxxxxxxxx> a écrit :
> On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
> >  jz4780-nemc needs to be compatible to simple-mfd as well or we get
> >
> >  arch/mips/boot/dts/ingenic/ci20.dtb: memory-controller@13410000: 
> > compatible: 'oneOf' conditional failed, one must be fixed:
> >  	['ingenic,jz4780-nemc', 'simple-mfd'] is too long
> >  	'ingenic,jz4725b-nemc' was expected
> >  	'ingenic,jz4740-nemc' was expected
> >  	From schema: 
> > Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml
> >
> >  Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
> >  ---
> >   .../devicetree/bindings/memory-controllers/ingenic,nemc.yaml    | 
> > 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >  diff --git 
> > a/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml 
> > b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml
> >  index 24f9e19820282..3b1116588de3d 100644
> >  --- 
> > a/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml
> >  +++ 
> > b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml
> >  @@ -17,7 +17,7 @@ properties:
> >       oneOf:
> >         - enum:
> >             - ingenic,jz4740-nemc
> >  -          - ingenic,jz4780-nemc
> >  +          - [ ingenic,jz4780-nemc, simple-mfd ]
>
> This is not correct representation. If you really need simple-mfd, 
> then
> this should be a separate item below oneOf.

Correct.

> The true question is whether you need simple-mfd. Isn't the binding 
> (and
> the driver) expected to instantiate its children?

I can explain that one. There is the EFUSE controller located inside 
the nemc's memory area, and the two are pretty much unrelated, hence 
the "simple-mfd" compatible string.

Cheers,
-Paul